-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTP Support #5627
FTP Support #5627
Conversation
I think this PR is almost ready. Needs add language resource later. |
This PR is looking very good. Only thing I think are left:
Issues:
|
Drag & drop from explorer to files does work.
This needs the streamed file be downloaded to local first before explorer can copy from it. |
Sorry, I meant the possibility to drag a file from a FTP location (inside Files) to a local folder (also in Files).. added :)
Indeed, I've just seen this, annoying. |
Oops I missed this one, thanks!
Seems that the context menu is created based on extension name. |
Do not show tags context menu item in FTP
Disable share toolbar button in FTP
I've just pushed a few changes, if you approve of them I think this is ready to be merged. |
LGTM. Thank you! I think we also need to add progress support for per file to reflect the download/upload progress after this PR is merged. |
Wish list.. no pressure 😂
|
@hez2010 thank you! |
@gave92 can you open a separate issue to track those? |
Resolved / Related Issues
Items resolved / related issues by this PR.
Details of Changes
Add FTP support.
Copy directoryOut of Scope
TODO
Validation
How did you test these changes?
Screenshots (optional)